Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused watchdog signal #5029

Merged

Conversation

demirkayaender
Copy link
Contributor

What changed?
Removed signal to the watchdog workflow

Why?
We added this watchdog to auto-clear Cassandra deletion resurrections when we encountered them. However, during outages/incidents this signal produces false positives. We are already addressing the issue on the storage layer so this watchdog won't be needed.
Deleting the signal right now, will cleanup the watchdog itself later.

How did you test it?

Potential risks

Release notes

Documentation Changes

@demirkayaender demirkayaender requested a review from a team November 18, 2022 19:40
@demirkayaender demirkayaender enabled auto-merge (squash) November 21, 2022 19:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 01848c41-bf01-4687-80cd-e6f4c6429713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 126 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.05%) to 57.297%

Files with Coverage Reduction New Missed Lines %
service/matching/taskListManager.go 2 77.11%
common/persistence/statsComputer.go 2 95.71%
service/history/task/transfer_standby_task_executor.go 2 86.82%
common/util.go 2 52.54%
common/persistence/executionManager.go 2 78.83%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
service/history/queue/timer_queue_processor_base.go 3 77.48%
service/history/shard/context.go 11 66.52%
service/history/execution/context.go 14 68.96%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 83.37%
Totals Coverage Status
Change from base Build 01848bde-9fdb-44ca-8911-39e4e6069246: -0.05%
Covered Lines: 85119
Relevant Lines: 148557

💛 - Coveralls

@demirkayaender demirkayaender merged commit 4b06e3f into cadence-workflow:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants